Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pvc): support kube_persistentvolumeclaim_deletion_timestamp #2074

Merged
merged 1 commit into from
Jul 26, 2023
Merged

feat(pvc): support kube_persistentvolumeclaim_deletion_timestamp #2074

merged 1 commit into from
Jul 26, 2023

Conversation

maxime1907
Copy link
Contributor

What this PR does / why we need it:
Adds a simple metric kube_persistentvolumeclaim_deletion_timestamp so that we can detect PVCs in "Terminating" state

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
increases

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1437

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 22, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 22, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @maxime1907!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 22, 2023
@maxime1907 maxime1907 force-pushed the featpvcdeletiontimestamp branch 4 times, most recently from b2a2550 to 636d302 Compare May 22, 2023 10:50
@maxime1907 maxime1907 mentioned this pull request May 23, 2023
Merged
@dgrisonnet
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 14, 2023
@maxime1907
feat(pvc): support kube_persistentvolumeclaim_deletion_timestamp
c0eb61a 
Signed-off-by: Maxime Leroy <19607336+maxime1907@users.noreply.github.com>
@maxime1907
Copy link
Contributor Author

any update on this ? @mrueg @dgrisonnet

@mrueg
Copy link
Member

mrueg commented Jul 26, 2023

/lgtm

Thanks a lot for your contribution!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maxime1907, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit 217acfc into kubernetes:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet left review comments

@mrueg mrueg mrueg left review comments

@fpetkovski fpetkovski Awaiting requested review from fpetkovski

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@mrueg mrueg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Terminating" status in kube_persistentvolumeclaim_status_phase metrics
4 participants
@maxime1907 @k8s-ci-robot @dgrisonnet @mrueg